Thanks Justin

By the way, I love git gui, just two buttons ("fetch from remote" and "merge local") and voila, all your changes are present in my local copy!

Frans

----- Original Message ----- From: "Justin J" justin@PROTECTED To: "Dada Mail Developers Subscriber" fransgnl@PROTECTED Sent: Saturday, November 07, 2009 12:05 AM Subject: [dadadev] Re: run-time error for function get_partial_list() using IE

> >

On Nov 6, 2009, at 10:54 PM, Frans Gouverne wrote:

>

It happens with IE6 and IE7, not with IE8

Yes, removing that comma solves the problem!

Awesome! Here's the commit that fixes everything that has code prototype/ajax like that (I think)

http://github com/justingit/dada-mail/commit/ea07d06344113317f437391b8304f3fddbb272b4

And here's the commit for the, "Strip Javascript from Webpages in the Send a Webpage screen"

http://github com/justingit/dada-mail/commit/7f2faa59498cdbba74d836f1ab7ab6ce47cb53a0

As always, I'd use the latest commit

Thanks again for all your feedback, Q/A, reminders, patience, etc :)

Justin J

Dada Mail - Write Once: Distribute Everywhere Software url: http://dadamailproject com

The Dada Mail Demo: http://demo dadamailproject com

On Nov 6, 2009, at 10:54 PM, Frans Gouverne wrote:

>

It happens with IE6 and IE7, not with IE8

Yes, removing that comma solves the problem!

Because the code is in a loop (tmpl_loop undotted_fields ), I had to change it as follows:

parameters: { f: 'previewMessageReceivers', alternative_lists: alternative_lists, multi_list_send_no_dupes: multi_list_send_no_dupes

},

So the comma is put at the start of tmpl_loop and one removed after "multi_list_send_no_dupes"

Now it works in IE6/7/8

Thanks,

Frans

----- Original Message ----- From: "Justin J" To: "Dada Mail Developers Subscriber" fransgnl@PROTECTED Sent: Friday, November 06, 2009 8:10 PM Subject: Re: run-time error for function get_partial_list() using IE

> > >

On Nov 6, 2009, at 1:47 PM, Frans Gouverne wrote:

When running Dada Mail version 4 0 0 beta 4 11/03/09 with f=f=send_email or f=send_url_email using Internet Explorer v7 0 5730 11, I do get the following popup:

---

A Runtime Error has occurred Do you wish to Debug?

Line: 835

Error: Expected identifier, string or number

Thanks for the report, Frans,

Can anyone else confirm this? I don't have IE8 myself, but all the latest versions of Safari, Firefox and Opera seem to be working, well

Also, are you doing some translating? Some of the paramaters:

                       field_comparison_type_voornaam: $F 

('field_comparison_type_voornaam'), field_value_voornaam:

Have been renamed :) Is this possibly a root of some of your problems?

I wonder if just taking that last comma off - so instead of:

field_comparison_type_achternaam: $F ('field_comparison_type_achternaam'), field_value_achternaam: $F('field_value_achternaam'),

Just have,

field_comparison_type_achternaam: $F ('field_comparison_type_achternaam'), field_value_achternaam: $F('field_value_achternaam')

Would help? I wonder if Javascript is that picky,

-- Justin J

Dada Mail - Write Once: Distribute Everywhere Software url: http://dadamailproject com

The Dada Mail Demo: http://demo dadamailproject com

On Nov 6, 2009, at 1:47 PM, Frans Gouverne wrote:

When running Dada Mail version 4 0 0 beta 4 11/03/09 with f=f=send_email or f=send_url_email using Internet Explorer v7 0 5730 11, I do get the following popup:

---

A Runtime Error has occurred Do you wish to Debug?

Line: 835

Error: Expected identifier, string or number

Looking at the source code, it is pointing to this part:

               parameters: {
                   f: 'previewMessageReceivers',
                   alternative_lists:         alternative_lists,
                   multi_list_send_no_dupes: 

multi_list_send_no_dupes,

                       field_comparison_type_email: $F 

('field_comparison_type_email'), field_value_email: $F ('field_value_email'),

                       field_comparison_type_voornaam: $F 

('field_comparison_type_voornaam'), field_value_voornaam: $F ('field_value_voornaam'),

                       field_comparison_type_achternaam: $F 

('field_comparison_type_achternaam'), field_value_achternaam: $F ('field_value_achternaam'),

==> line 835 is here !! },

When I remove function get_partial_list() from file "partial_sending_options_widget tmpl" the error is gone The error is also gone when I remove everything from the inner block of parameters: {}

Also, when I press the button "Preview Whi Is Getting This Message " (Patrial Mailing List Sending) I get the following popup:

---

A Runtime Error has occurred Do you wish to Debug?

Line: 764

Error: Object expected

which is expected because at line 764 get_partial_list() is called:

<input type="button" value="Preview Who's Getting This 

Message " class="cautionary" onClick="get_partial_list()" />

No problems with FireFox

Post: mailto:dadadev@dadamailproject com

Unsubscribe: http://dadamailproject com/cgi-bin/dada/mail cgi/u/dadadev/

List Information: http://dadamailproject com/cgi-bin/dada/mail cgi/list/dadadev

Archive: http://dadamailproject com/cgi-bin/dada/mail cgi/archive/dadadev

Mailing List Powered by Dada Mail

--

Post: dadadev@PROTECTED

Unsubscribe: http://dadamailproject com/cgi-bin/dada/mail cgi/u/dadadev/

List Information:

Archive:

Mailing List Powered by Dada Mail http://dadamailproject com/cgi-bin/dada/mail cgi/what_is_dada_mail/

--

Post: dadadev@PROTECTED

Unsubscribe: http://dadamailproject com/cgi-bin/dada/mail cgi/u/dadadev/

List Information:

Archive:

Mailing List Powered by Dada Mail http://dadamailproject com/cgi-bin/dada/mail cgi/what_is_dada_mail/

--

Post: dadadev@PROTECTED

Unsubscribe: http://dadamailproject com/cgi-bin/dada/mail cgi/u/dadadev/

List Information: http://dadamailproject com/cgi-bin/dada/mail cgi/list/dadadev

Archive: http://dadamailproject com/cgi-bin/dada/mail cgi/archive/dadadev

Mailing List Powered by Dada Mail http://dadamailproject com/cgi-bin/dada/mail cgi/what_is_dada_mail/