Speedup, "Add" screen significantly

 
From: "Dada Mail" <dada@PROTECTED>
Date: May 24th 2007

Hey everyone,

I've been playing around with how to speed up the, "Add Subscribers"
screen in Dada Mail At the moment, it's glacial I was under the
impression that it's this way simply because the validation process
is resource intensive and if you do something like the validation
process for, say, 10,000 subscribers, it's just gonna take some time

Well, there is some room for improvement and have some fun and try
this out:

In the dada/DADA/MailingList/Subscribers pm file, find these lines:

[snip]

foreach my $check_this_address(@$new_addresses) {

    my ($status, $errors) = $self->subscription_check(-Email =>  

$check_this_address, -Type => $args{- Type}, -Skip => [qw( no_list

subscribed

blacklisted

not_white_listed

closed_list

mx_lookup_failed

already_sent_sub_confirmation

already_sent_unsub_confirmation )], );

[snip/]

In the, filter_subscribers subroutine and replace them with:

[snip] my $num_subscribers = $self->num_subscribers;

foreach my $check_this_address(@$new_addresses) {


     my $errors = {};
     my $status = 1;

     $errors->{invalid_email} = 1 if  

DADA::App::Guts::check_for_valid_email($check_this_address) == 1;

     if($args{-Type} ne 'black_list' || $args{-Type} ne  

'moderators'){ if($li->{use_subscription_quota} == 1){ if(($num_subscribers + 1) >= $li-> {subscription_quota}){ $errors->{over_subscription_quota} = 1; } } }

     if( $errors->{invalid_email} == 1 || $errors-> 

{over_subscription_quota} == 1){ $status = 0; }

[/snip]

And enjoy the speedup On my not very scientific tests, submitting a
10,000 addressed list of hopeful subscribers gave me a result in
seconds Doing it the old way took 5 10? minutes - I don't know, I
never had the patience to wait around My subscriber list was very
small, so your mileage my vary, but this couldn't hurt anything,
that's for sure Going to do some more testing

Cheers,

  • This mailing list is a public mailing list - anyone may join or leave, at any time.
  • This mailing list is a group discussion list (unmoderated)
  • Start a new thread, email: dadadev@dadamailproject.com

This is the developer discussion mailing list for Dada Mail.

If you are just looking for support Dada Mail, consult the message boards at:

https://forum.dadamailproject.com

Documentation for Dada Mail:

https://dadamailproject.com/d

Specifically, see the Error FAQ:

https://dadamailproject.com/d/FAQ-errors.pod.html

To post to this list, send a message to:

mailto:dadadev@dadamailproject.com

All subscribers of this list may post to the list itself.

Topics that are welcome:

  • Constructive critiques on the program (I like, "x", but, "y" needs some work - here's an idea on how to make this better...)
  • Bug/Error reports
  • Bug fixes
  • Request For Comments on any changes to the program
  • Help customizing Dada Mail for your own needs
  • Patches
  • Language Translations
  • Support Documentation/Doc editing, FAQ's, etc.
  • Discussion of any changes that you would like to be committed to the next version of Dada Mail -

Dada Mail is on Github:

https://github.com/justingit/dada-mail/

If you would like to fork, branch, send over PRs, open up issues, etc.

Privacy Policy:

This Privacy Policy is for this mailing list, and this mailing list only.

Email addresses collection through this mailing list are used explicitly to work within this email discussion list.

We only collect email addresses through our Closed-Loop Opt-In system.

We don't use your email address for any other purpose.

We won't be sharing your email address with any other entity.

Unsubscription can be done at any time. Please contact us at: justin@dadamailproject.com for any help regarding your subscription, including removal from the mailing list.

All mailing list messages sent from us will include a subscription removal link, which will allow you to remove yourself from this mailing list automatically, and permanently.

All consent to use your email address for any other purpose stated at the time of the mailing list subscription will also be revoked upon mailing list removal.