Justin,

Congrats on the new release of dada mail

<< I think the three examples you've given could be valid statements you could have an a email header, for example, what you'll see in the, "To:", "From:", etc headers, but right now, Dada Mail only saves the, "here@example" address >>

Yes, I know

<< At this point, I think it would be a better idea to have the "Real" First name, and "Real" last name in separate fields, as well as having the address separate, when saving this information If Mailman works a little differently, this may just be a different design decision by them >>

Of course you want to focus on adding field support since you've made a public commitment to do so, but does that mean I have to? It seems to me that your address validation code is just plain wrong to be rejecting/trashing valid email addresses, that calling that a feature or suggesting it's merely a design decision can't make it not-a-bug

You didn't address my concern that the regex expression you're using for address validation is indecipherable to humans In your source code there's a comment that points to a URL that is supposed to help explain it, but that link is invalid In any case, that particular line of code looks like gibberish, an unwise design choice See code enclosed below

Just an opinion, your code generally uses a little too much Perl wizardry and hackerisms to be easy to maintain for others I've seen worse in other projects, but better is possible It would be helpful if all the code was in subroutines so there are clear entry and exit points Perl doesn't require this, but doing so makes large projects easier to understand

In order to be able to use dada mail I have to be able to import email addresses non-destructively What you suggest would lose information To strip off the person names to have bare email addresses is in no way an acceptable work-around

Can you give me any suggestions where in your code I'll need to make modifications to fix this bug? Do you want help fixing this bug or am I on my own?

Thank you,

Robin

Excerpt from Valid pm:

Regular expression built using Jeffrey Friedl's example in

Mastering Regular Expressions (http://www ora com/catalog/regexp/)

$RFC822PAT = <<'EOF'; [\040\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\xff]|([^\\x80-\ xff\n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\015()])))[^\\x80-\xf f\n\015()]))[\040\t])(?:(?:[^(\040)<>@,;:" \[]\000-\037\x80-\x ff]+(?![^(\040)<>@,;:" \[]\000-\037\x80-\xff])|"[^\\x80-\xff\n\015 "](?:\[^\x80-\xff][^\\x80-\xff\n\015"])")[\040\t](?:([^\\x80-\ xff\n\015()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^\x80 -\xff][^\\x80-\xff\n\015()])))[^\\x80-\xff\n\015()]))[\040\t] )(?: [\040\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\xff]|([^\ \x80-\xff\n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\015()])))[^\\ x80-\xff\n\015()]))[\040\t])(?:[^(\040)<>@,;:" \[]\000-\037\x8 0-\xff]+(?![^(\040)<>@,;:" \[]\000-\037\x80-\xff])|"[^\\x80-\xff\n \015"](?:\[^\x80-\xff][^\\x80-\xff\n\015"])")[\040\t](?:([^\\x 80-\xff\n\015()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^ \x80-\xff][^\\x80-\xff\n\015()])))[^\\x80-\xff\n\015()]))[\040 \t]))@[\040\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\xff]|([ ^\\x80-\xff\n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\015()])))[^\ \x80-\xff\n\015()]))[\040\t])(?:[^(\040)<>@,;:" \[]\000-\037\ x80-\xff]+(?![^(\040)<>@,;:" \[]\000-\037\x80-\xff])|[(?:[^\\x80- \xff\n\015[]]|\[^\x80-\xff])])[\040\t](?:([^\\x80-\xff\n\015() ](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^\x80-\xff][^\\ x80-\xff\n\015()])))[^\\x80-\xff\n\015()]))[\040\t])(?: [\04 0\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\ n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\015()])))[^\\x80-\xff\n\ 015()]))[\040\t])(?:[^(\040)<>@,;:" \[]\000-\037\x80-\xff]+(?! [^(\040)<>@,;:" \[]\000-\037\x80-\xff])|[(?:[^\\x80-\xff\n\015[\ ]]|\[^\x80-\xff])])[\040\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\ x80-\xff]|([^\\x80-\xff\n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\01 5()])))[^\\x80-\xff\n\015()]))[\040\t]))|(?:[^(\040)<>@,;:" \[]\000-\037\x80-\xff]+(?![^(\040)<>@,;:" \[]\000-\037\x80-\xff] )|"[^\\x80-\xff\n\015"](?:\[^\x80-\xff][^\\x80-\xff\n\015"])")[^ ()<>@,;:" \[]\x80-\xff\000-\010\012-\037](?:(?:([^\\x80-\xff\n\0 15()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^\x80-\xff][ ^\\x80-\xff\n\015()])))[^\\x80-\xff\n\015()]))|"[^\\x80-\xff\ n\015"](?:\[^\x80-\xff][^\\x80-\xff\n\015"])")[^()<>@,;:" \[]\ x80-\xff\000-\010\012-\037])<[\040\t](?:([^\\x80-\xff\n\015()](? :(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^\x80-\xff][^\\x80- \xff\n\015()])))[^\\x80-\xff\n\015()]))[\040\t])(?:@[\040\t]* (?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015 ()](?:\[^\x80-\xff][^\\x80-\xff\n\015()])))[^\\x80-\xff\n\015() ]))[\040\t])(?:[^(\040)<>@,;:" \[]\000-\037\x80-\xff]+(?![^(\0 40)<>@,;:" \[]\000-\037\x80-\xff])|[(?:[^\\x80-\xff\n\015[]]|\ [^\x80-\xff])])[\040\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\ xff]|([^\\x80-\xff\n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\015()]* )))[^\\x80-\xff\n\015()]))[\040\t])(?: [\040\t](?:([^\\x80 -\xff\n\015()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^\x 80-\xff][^\\x80-\xff\n\015()])))[^\\x80-\xff\n\015()]))[\040\t ])(?:[^(\040)<>@,;:" \[]\000-\037\x80-\xff]+(?![^(\040)<>@,;:" \ []\000-\037\x80-\xff])|[(?:[^\\x80-\xff\n\015[]]|\[^\x80-\xff]) ])[\040\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\xff]|([^\\x 80-\xff\n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\015()])))[^\\x80 -\xff\n\015()]))[\040\t]))(?:,[\040\t](?:([^\\x80-\xff\n\015( )](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^\x80-\xff][^\ \x80-\xff\n\015()])))[^\\x80-\xff\n\015()]))[\040\t])@[\040\t ](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\0 15()](?:\[^\x80-\xff][^\\x80-\xff\n\015()])))[^\\x80-\xff\n\015 ()]))[\040\t])(?:[^(\040)<>@,;:" \[]\000-\037\x80-\xff]+(?![^( \040)<>@,;:" \[]\000-\037\x80-\xff])|[(?:[^\\x80-\xff\n\015[]]| \[^\x80-\xff])])[\040\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80 -\xff]|([^\\x80-\xff\n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\015() ])))[^\\x80-\xff\n\015()]))[\040\t])(?: [\040\t](?:([^\\x 80-\xff\n\015()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^ \x80-\xff][^\\x80-\xff\n\015()])))[^\\x80-\xff\n\015()]))[\040 \t])(?:[^(\040)<>@,;:" \[]\000-\037\x80-\xff]+(?![^(\040)<>@,;:" \[]\000-\037\x80-\xff])|[(?:[^\\x80-\xff\n\015[]]|\[^\x80-\xff ])])[\040\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\xff]|([^\ \x80-\xff\n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\015()])))[^\\x 80-\xff\n\015()]))[\040\t]))):[\040\t](?:([^\\x80-\xff\n\015 ()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^\x80-\xff][^\ \x80-\xff\n\015()])))[^\\x80-\xff\n\015()]))[\040\t]))?(?:[^ (\040)<>@,;:" \[]\000-\037\x80-\xff]+(?![^(\040)<>@,;:" \[]\000- \037\x80-\xff])|"[^\\x80-\xff\n\015"](?:\[^\x80-\xff][^\\x80-\xff\ n\015"])")[\040\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\xff]| ([^\\x80-\xff\n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\015()]))) [^\\x80-\xff\n\015()]))[\040\t])(?: [\040\t](?:([^\\x80-\xff \n\015()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^\x80-\x ff][^\\x80-\xff\n\015()])))[^\\x80-\xff\n\015()]))[\040\t])( ?:[^(\040)<>@,;:" \[]\000-\037\x80-\xff]+(?![^(\040)<>@,;:" \[]\ 000-\037\x80-\xff])|"[^\\x80-\xff\n\015"](?:\[^\x80-\xff][^\\x80-\ xff\n\015"])")[\040\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\x ff]|([^\\x80-\xff\n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\015()]) *))[^\\x80-\xff\n\015()]))[\040\t]))@[\040\t](?:([^\\x80-\x ff\n\015()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^\x80- \xff][^\\x80-\xff\n\015()])))[^\\x80-\xff\n\015()]))[\040\t]) (?:[^(\040)<>@,;:" \[]\000-\037\x80-\xff]+(?![^(\040)<>@,;:" \[\ ]\000-\037\x80-\xff])|[(?:[^\\x80-\xff\n\015[]]|\[^\x80-\xff])] )[\040\t](?:([^\\x80-\xff\n\015()](?:(?:\[^\x80-\xff]|([^\\x80- \xff\n\015()](?:\[^\x80-\xff][^\\x80-\xff\n\015()])))[^\\x80-\x ff\n\015()]))[\040\t])(?: [\040\t](?:([^\\x80-\xff\n\015()]( ?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()](?:\[^\x80-\xff][^\\x80 -\xff\n\015()])))[^\\x80-\xff\n\015()]))[\040\t])(?:[^(\040)<

@,;:" \[]\000-\037\x80-\xff]+(?![^(\040)<>@,;:" \[]\000-\037\x8 0-\xff])|[(?:[^\\x80-\xff\n\015[]]|\[^\x80-\xff])])[\040\t](?: ([^\\x80-\xff\n\015()](?:(?:\[^\x80-\xff]|([^\\x80-\xff\n\015()] *(?:\[^\x80-\xff][^\\x80-\xff\n\015()])))[^\\x80-\xff\n\015()]) )[\040\t]))>) EOF

$RFC822PAT =~ s/\n//g;