Re: beatitude scheduled time problems
On Mar 12, 2012, at 5:32 AM, Mariano Absatz - gmail wrote:
I also have my crontab file with environment variables to that effect and, other than the bug described, the site AND crontab do work OK with Buenos Aires' times
Hmm, I didn't know you could set environmental variables in a cronjob (except for, MAILTO, which I'm not sure is really a env var) - I'm still not quite sure, but it's not going to set for the cronjob for Beatitude, since the cronjob will just start an HTTP process, which will have its own environment
Anyways, I can recreate your problem - it probably has to do with this method in dada/DADA/MailingList/Schedules pm It turns the data you set in the form into something that time() would return:
sub mailing_date {
my $self = shift;
my $q = shift;
my $min = $q->param('mail_minute') || 0;
my $hour = $q->param('mail_hour') || 0;
my $mday = $q->param('mail_day') || 1;
my $mon = $q->param('mail_month') || 0;
my $year = $q->param('mail_year') || 0;
my $mail_am_pm = $q->param('mail_am_pm') || 'am';
# This is a little hacky
if ( $mail_am_pm eq 'pm' ) {
# But - if the hour is, "12"
# 12 + 12 is, "24" - not, "0' and not just, "12"
if ( $hour != 12 ) {
$hour += 12;
}
}
elsif ( $mail_am_pm eq 'am' ) {
if ( $hour == 12 ) {
$hour = 0;
}
}
$min = int($min);
require Time::Local;
my $time = Time::Local::timelocal( 0, $min, $hour, $mday, $mon, $year );
return $time;
}
I bet the bug is in the, "am" and "pm" check Working with a 24 hour clock would be a ton simpler,
- This mailing list is a public mailing list - anyone may join or leave, at any time.
- This mailing list is a group discussion list (unmoderated)
-
Start a new thread, email: dadadev@dadamailproject.com
This is the developer discussion mailing list for Dada Mail.
If you are just looking for support Dada Mail, consult the message boards at:
https://forum.dadamailproject.com
Documentation for Dada Mail:
Specifically, see the Error FAQ:
https://dadamailproject.com/d/FAQ-errors.pod.html
To post to this list, send a message to:
mailto:dadadev@dadamailproject.com
All subscribers of this list may post to the list itself.
Topics that are welcome:
- Constructive critiques on the program (I like, "x", but, "y" needs some work - here's an idea on how to make this better...)
- Bug/Error reports
- Bug fixes
- Request For Comments on any changes to the program
- Help customizing Dada Mail for your own needs
- Patches
- Language Translations
- Support Documentation/Doc editing, FAQ's, etc.
- Discussion of any changes that you would like to be committed to the next version of Dada Mail -
Dada Mail is on Github:
https://github.com/justingit/dada-mail/
If you would like to fork, branch, send over PRs, open up issues, etc.
Privacy Policy:
This Privacy Policy is for this mailing list, and this mailing list only.
Email addresses collection through this mailing list are used explicitly to work within this email discussion list.
We only collect email addresses through our Closed-Loop Opt-In system.
We don't use your email address for any other purpose.
We won't be sharing your email address with any other entity.
Unsubscription can be done at any time. Please contact us at: justin@dadamailproject.com for any help regarding your subscription, including removal from the mailing list.
All mailing list messages sent from us will include a subscription removal link, which will allow you to remove yourself from this mailing list automatically, and permanently.
All consent to use your email address for any other purpose stated at the time of the mailing list subscription will also be revoked upon mailing list removal.