Re: half bug/half new feature
From:
"Carl G. Kuczun" <ckuczun@PROTECTED>
In-Reply-To:
Re: half bug/half new feature
Date:
December 18th 2008
Justin,
I made the changes you provided (below) that put
the existing subscriber fields in the unsubscribe email notice before removing
the subscriber. I needed to modify the following line after pasting in the
change:
# We move, in an attempt to keep the subscription information
because the last word wrapped to a new line causing a
compile error. My testing still puts blank subscriber fields in the
unsubscribe email. Can you double check the code and confirm that it is
right? Thanks.
Carl K
----- Original Message -----
From: "Justin J" <justin@PROTECTED>
To: "Dada Mail Developers Subscriber" <ckuczun@PROTECTED>
Sent: Tuesday, December 16, 2008 2:21
AM
Subject: [dadadev] Re: half bug/half new feature
>
>
> On Dec 15, 2008, at 9:06 PM, Carl G. Kuczun wrote:
>
>
>>
>> Here is half bug/half new feature that you might consider for an
>> upcoming release. I think it might be an easy one. Right now when
>> someone subscribes, they can fill in the subscriber fields and the
>> subscription notification email that I receive correctly includes
>> their email address AND the subscription fields. However when
>> someone unsubscribes, all I get is the email address. The
>> subscription fields are blank, even if they re-entered the
>> subscription fields when unsubscribing. That's the bug part.
>>
>> The new feature part would be to, instead, put the already stored
>> information from the subscription fields into the unsubscribe
>> notification email. So when someone unsubscribes, I am presented
>> with what was in their record in the database. I often get
>> unsubscribes and have no idea from the email address who it was.
>
>
> I think what Dada Mail is doing is unsubscribing the email address,
> before sending out the, "hey, I've unsubscribed the email address!"
> Once it unsubscribes the address, there's no information left about
> the subscribers - so none of the information in the fields is
> available *to* use. I can see the value in having those fields
> available in that email though.
>
>
> You can probably do a quick tweak of the code like this - just send
> out the message, before the subscriber is removed. In the dada/DADA/
> App/Subscriptions.pm file.
>
>
> Find these lines (there's a few)
>
>
>
>
>
>
> if(
> $li->{black_list} == 1 &&
> $li->{add_unsubs_to_black_list} == 1
>
>
> ){
>
>
>
> # Basically, what I gotta do is make sure that there aren't on the
> # Blacklist ALREADY, or Baaaaaaad things happen.
>
> # We move, in an attempt to keep the subscription
> information
> # Perhaps, they'll be moved back?
>
>
> warn 'Moving email (' . $email .') to blacklist.'
> if $t;
>
>
> $lh->move_subscriber(
>
>
> {
> -email => $email,
> -from => 'list',
> -to => 'black_list',
> -mode => 'writeover',
> }
> );
>
>
> }
> else {
>
>
> $lh->remove_from_list(
> -Email_List =>[$email],
> -Type => 'list'
> );
>
>
> }
>
>
> require DADA::App::Messages;
> DADA::App::Messages::send_owner_happenings(
> {
> -list => $list,
> -email => $email,
> -role => "unsubscribed",
> -test => $self->test,
> }
> );
>
>
>
>
>
>
>
>
>
>
>
>
> and change them to:
>
>
>
>
> require DADA::App::Messages;
> DADA::App::Messages::send_owner_happenings(
> {
> -list => $list,
> -email => $email,
> -role => "unsubscribed",
> -test => $self->test,
> }
> );
>
>
>
>
>
>
>
>
> if(
> $li->{black_list} == 1 &&
> $li->{add_unsubs_to_black_list} == 1
>
>
> ){
>
>
>
> # Basically, what I gotta do is make sure that there aren't on the
> # Blacklist ALREADY, or Baaaaaaad things happen.
>
> # We move, in an attempt to keep the subscription
> information
> # Perhaps, they'll be moved back?
>
>
> warn 'Moving email (' . $email .') to blacklist.'
> if $t;
>
>
> $lh->move_subscriber(
>
>
> {
> -email => $email,
> -from => 'list',
> -to => 'black_list',
> -mode => 'writeover',
> }
> );
>
>
> }
> else {
>
>
> $lh->remove_from_list(
> -Email_List =>[$email],
> -Type => 'list'
> );
>
>
> }
>
>
>
>
>
>
> The better fix may be to grab that information, before they're
> unsubscribed, unsubscribe them and then send that message out, just to
> be thorough :)
>
>
> --
> Justin J.
>
>
> Dada Mail - Write Once: Distribute Everywhere Software
> url: http://dadamailproject.com
>
>
> Demo:
> http://demo.dadamailproject.com
>
>
> Seen Dada Mail 3?
> http://dadamailproject.com/features/3_0/
>
>
> On Dec 15, 2008, at 9:06 PM, Carl G. Kuczun wrote:
>
>
>>
>> Here is half bug/half new feature that you might consider for an
>> upcoming release. I think it might be an easy one. Right now when
>> someone subscribes, they can fill in the subscriber fields and the
>> subscription notification email that I receive correctly includes
>> their email address AND the subscription fields. However when
>> someone unsubscribes, all I get is the email address. The
>> subscription fields are blank, even if they re-entered the
>> subscription fields when unsubscribing. That's the bug part.
>>
>> The new feature part would be to, instead, put the already stored
>> information from the subscription fields into the unsubscribe
>> notification email. So when someone unsubscribes, I am presented
>> with what was in their record in the database. I often get
>> unsubscribes and have no idea from the email address who it was.
>>
>> Carl
>>
>> ----- Original Message ----- From: "Justin J" <justin@PROTECTED
>> >
>> To: "Dada Mail Developers Subscriber" <ckuczun@PROTECTED>
>> Sent: Monday, December 15, 2008 3:51 AM
>> Subject: Re: dadadev {Spam?} Re: FW: Wish List Feature
>>
>>
>>>
>>> On Dec 14, 2008, at 10:57 PM, Carl G. Kuczun wrote:
>>>
>>>
>>>>
>>>> I'll certainly test the new version as a separate install from
>>>> 3.0.1. But I keep coming back to my main question which is "is
>>>> there any code I can sneak into 3.0.1 to default a new list to an
>>>> existing list?" It seems there was a simple, 15-line solution
>>>> for the previous release (2.x) and one for 3.1 - but is there
>>>> something we can add (unofficially, of course) to 3.0.1?
>>>
>>>
>>> I think the best thing for me to do is work on new features on the
>>> new version of Dada Mail. I'll leave it to other people to
>>> backwards port things, if they want - I'll even put the 3.0.1
>>> version in a git repo, with the bugfixes I've been applying
>>> (currently, it's still available in CVS), but I'm going to go
>>> loco, trying to back port cherry-picked features into the bugfix-
>>> only releases.
>>>
>>>
>>> Can someone else help Carl?
>>>
>>>
>>> --
>>> Justin J.
>>>
>>>
>>> Dada Mail - Write Once: Distribute Everywhere Software
>>> url: http://dadamailproject.com
>>>
>>>
>>> Demo:
>>> http://demo.dadamailproject.com
>>>
>>>
>>> Seen Dada Mail 3?
>>> http://dadamailproject.com/features/3_0/
>>>
>>>
>>> On Dec 14, 2008, at 10:57 PM, Carl G. Kuczun wrote:
>>>
>>>
>>>>
>>>> I'll certainly test the new version as a separate install from
>>>> 3.0.1. But I keep coming back to my main question which is "is
>>>> there any code I can sneak into 3.0.1 to default a new list to an
>>>> existing list?" It seems there was a simple, 15-line solution
>>>> for the previous release (2.x) and one for 3.1 - but is there
>>>> something we can add (unofficially, of course) to 3.0.1?
>>>>
>>>> Carl K
>>>>
>>>> ----- Original Message ----- From: "Justin J" <justin@PROTECTED
>>>> >
>>>> To: "Dada Mail Developers Subscriber" <ckuczun@PROTECTED>
>>>> Sent: Sunday, December 14, 2008 9:21 PM
>>>> Subject: Re: dadadev {Spam?} Re: FW: Wish List Feature
>>>>
>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Dec 14, 2008, at 7:11 PM, Carl G. Kuczun wrote:
>>>>>>
>>>>>> Can this be installed over Dada Pro, or do you need to provide a
>>>>>> separate link for that?
>>>>>
>>>>>
>>>>> The changes are based on the 3.1 MAIN CVS branch, which is quite
>>>>> different from the 3.0.1 bugfix branch the current, stable
>>>>> version of Dada Mail is based on.
>>>>>
>>>>>
>>>>> You can *probably* install right over 3.0.1 - but it's a
>>>>> different beast, is in development, is NOT stable, has bugs, is a
>>>>> work in progress, etc,
>>>>>
>>>>>
>>>>> I'm not putting any new features (officially) into anything
>>>>> based on 3.0.1, the only thing I may do is release another
>>>>> bugfix release. It's what's on Github from now on. The official
>>>>> stable release based on what's there won't be for another few
>>>>> months. It's a long time, so that's why it's really nice to be
>>>>> able to grab whatever from github and try it out and see how it
>>>>> works for you in a purely testing situation.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> I mean, YMMV :)
>>>>>
>>>>>
>>>>> --
>>>>> Justin J.
>>>>>
>>>>>
>>>>> Dada Mail - Write Once: Distribute Everywhere Software
>>>>> url: http://dadamailproject.com
>>>>>
>>>>>
>>>>> Demo:
>>>>> http://demo.dadamailproject.com
>>>>>
>>>>>
>>>>> Seen Dada Mail 3?
>>>>> http://dadamailproject.com/features/3_0/
>>>>>
>>>>>
>>>>> On Dec 14, 2008, at 7:11 PM, Carl G. Kuczun wrote:
>>>>>
>>>>>
>>>>>>
>>>>>> Justin - I was able to download the code from github.com, but I
>>>>>> had to use the Firefox browser. The Microsoft Internet
>>>>>> Explorer wouldn't do anything when the download button was
>>>>>> clicked. Not the first time MSIE doesn't play well with others.
>>>>>>
>>>>>> Can this be installed over Dada Pro, or do you need to provide a
>>>>>> separate link for that?
>>>>>>
>>>>>> Carl K
>>>>>>
>>>>>> ----- Original Message ----- From: "Justin J" <justin@PROTECTED
>>>>>> >
>>>>>> To: "Dada Mail Developers Subscriber" <ckuczun@PROTECTED>
>>>>>> Sent: Sunday, December 14, 2008 2:56 AM
>>>>>> Subject: Re: dadadev {Spam?} Re: FW: Wish List Feature
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>> Thank you for the code snippets below. It looks exactly like
>>>>>>>> what I am looking for. Can you be more specific where these
>>>>>>>> should be put?
>>>>>>>
>>>>>>>
>>>>>>> The changes are for a pretty old version of Dada Mail - the
>>>>>>> API has changed enough where you wouldn't be able to apply
>>>>>>> them to anything made in the 3.x series...
>>>>>>>
>>>>>>>
>>>>>>> But!
>>>>>>>
>>>>>>>
>>>>>>> But, I took a little time and made it a feature in the dev
>>>>>>> version of Dada Mail, and (I *think*) through the power of
>>>>>>> Git, you can grab it from the download link at:
>>>>>>>
>>>>>>>
>>>>>>> http://github.com/justingit/dada-mail/commit/af94a118aca387a1c290be908f96e9d5d847d19a
>>>>>>>
>>>>>>>
>>>>>>> Which is pretty cool.
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Justin J.
>>>>>>>
>>>>>>>
>>>>>>> Dada Mail - Write Once: Distribute Everywhere Software
>>>>>>> url: http://dadamailproject.com
>>>>>>>
>>>>>>>
>>>>>>> Demo:
>>>>>>> http://demo.dadamailproject.com
>>>>>>>
>>>>>>>
>>>>>>> Seen Dada Mail 3?
>>>>>>> http://dadamailproject.com/features/3_0/
>>>>>>>
>>>>>>>
>>>>>>> On Dec 10, 2008, at 10:09 PM, Carl G. Kuczun wrote:
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> Hi Frans,
>>>>>>>>
>>>>>>>> Thank you for the code snippets below. It looks exactly like
>>>>>>>> what I am looking for. Can you be more specific where these
>>>>>>>> should be put?
>>>>>>>>
>>>>>>>> Carl K
>>>>>>>> ----- Original Message -----
>>>>>>>> From: Frans Gouverne
>>>>>>>> To: Dada Mail Developers Subscriber
>>>>>>>> Sent: Wednesday, November 26, 2008 4:16 AM
>>>>>>>> Subject: dadadev {Spam?} Re: FW: Wish List Feature
>>>>>>>> Request for this feature has been showing up several times
>>>>>>>> the last few years. I already implemented this feature
>>>>>>>> myself because my users of dada are non-technical guys and
>>>>>>>> they are using 3 different kind of lists (discussion,
>>>>>>>> anounce only, hiddden). They have really no idea how to
>>>>>>>> change all options to meet a specific list so that's why
>>>>>>>> such a feature is great to have. Below a snapshot of my
>>>>>>>> solution (based on version 2.10 as you can see). By
>>>>>>>> default, the default options from the config file are being
>>>>>>>> used. It does not cause confusion this way in my experience.
>>>>>>>>
>>>>>>>>
>>>>>>>> <Create a New List_1227689127352.png>
>>>>>>>>
>>>>>>>> The two code snippets for v2.10 (first for creating the
>>>>>>>> select box, second for copying the LIST_SETUP_DEFAULTS) :
>>>>>>>>
>>>>>>>> sub new_list:
>>>>>>>> ===========
>>>>>>>>
>>>>>>>> my $configuration_lists;
>>>>>>>> my @lists = available_lists();
>>>>>>>> my %labels = ('default' => 'default list');
>>>>>>>>
>>>>>>>> $labels{$_} = $_ foreach @lists;
>>>>>>>>
>>>>>>>> $configuration_lists = $q->popup_menu(
>>>>>>>> -values => ['default',@lists],
>>>>>>>> -labels => {%labels},
>>>>>>>> -default => 'default',
>>>>>>>> -name => 'configuration_lists',
>>>>>>>> );
>>>>>>>>
>>>>>>>> and:
>>>>>>>> ====
>>>>>>>>
>>>>>>>>
>>>>>>>> if($q->param('configuration_lists') ne 'default'){
>>>>>>>> my $ls_conf = DADA::MailingList::Settings->new(-List => $q-
>>>>>>>> >param('configuration_lists'));
>>>>>>>> $ls_conf = $ls_conf->get;
>>>>>>>> foreach my $setup (keys %LIST_SETUP_DEFAULTS) {
>>>>>>>> $new_info{"$setup"} = $ls_conf->{$setup};
>>>>>>>> }
>>>>>>>> }
>>>>>>>>
>>>>>>>>
>>>>>>>> Post:
>>>>>>>> mailto:dadadev@PROTECTED
>>>>>>>>
>>>>>>>> Unsubscribe:
>>>>>>>> http://dadamailproject.com/cgi-bin/dada/mail.cgi/u/dadadev/
>>>>>>>>
>>>>>>>> List Information:
>>>>>>>> http://dadamailproject.com/cgi-bin/dada/mail.cgi/list/dadadev
>>>>>>>>
>>>>>>>> Archive:
>>>>>>>> http://dadamailproject.com/cgi-bin/dada/mail.cgi/archive/dadadev
>>>>>>>>
>>>>>>>> Post:
>>>>>>>> mailto:dadadev@PROTECTED
>>>>>>>>
>>>>>>>> Unsubscribe:
>>>>>>>> http://dadamailproject.com/cgi-bin/dada/mail.cgi/u/dadadev/
>>>>>>>>
>>>>>>>> List Information:
>>>>>>>> http://dadamailproject.com/cgi-bin/dada/mail.cgi/list/dadadev
>>>>>>>>
>>>>>>>> Archive:
>>>>>>>> http://dadamailproject.com/cgi-bin/dada/mail.cgi/archive/dadadev
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> Post: <mailto:dadadev@PROTECTED>
>>>>>>>
>>>>>>> Unsubscribe:
>>>>>>> <http://dadamailproject.com/cgi-bin/dada/mail.cgi/u/dadadev/>
>>>>>>>
>>>>>>> List Information: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/list/dadadev
>>>>>>> >
>>>>>>>
>>>>>>> Archive: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/archive/dadadev
>>>>>>> >
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Post: <mailto:dadadev@PROTECTED>
>>>>>>
>>>>>> Unsubscribe:
>>>>>> <http://dadamailproject.com/cgi-bin/dada/mail.cgi/u/dadadev/>
>>>>>>
>>>>>> List Information: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/list/dadadev
>>>>>> >
>>>>>>
>>>>>> Archive: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/archive/dadadev
>>>>>> >
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> Post: <mailto:dadadev@PROTECTED>
>>>>>
>>>>> Unsubscribe:
>>>>> <http://dadamailproject.com/cgi-bin/dada/mail.cgi/u/dadadev/>
>>>>>
>>>>> List Information: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/list/dadadev
>>>>> >
>>>>>
>>>>> Archive: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/archive/dadadev
>>>>> >
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Post: <mailto:dadadev@PROTECTED>
>>>>
>>>> Unsubscribe:
>>>> <http://dadamailproject.com/cgi-bin/dada/mail.cgi/u/dadadev/>
>>>>
>>>> List Information: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/list/dadadev
>>>> >
>>>>
>>>> Archive: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/archive/dadadev
>>>> >
>>>
>>>
>>>
>>> --
>>>
>>> Post: <mailto:dadadev@PROTECTED>
>>>
>>> Unsubscribe:
>>> <http://dadamailproject.com/cgi-bin/dada/mail.cgi/u/dadadev/>
>>>
>>> List Information: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/list/dadadev
>>> >
>>>
>>> Archive: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/archive/dadadev
>>> >
>>
>>
>>
>> --
>>
>> Post: <mailto:dadadev@PROTECTED>
>>
>> Unsubscribe:
>> <http://dadamailproject.com/cgi-bin/dada/mail.cgi/u/dadadev/>
>>
>> List Information: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/list/dadadev
>> >
>>
>> Archive: <http://dadamailproject.com/cgi-bin/dada/mail.cgi/archive/dadadev
>> >
>
>
>
> --
>
> Post:
> <mailto:dadadev@PROTECTED>
>
> Unsubscribe:
> <http://dadamailproject.com/cgi-bin/dada/mail.cgi/u/dadadev/>
>
> List Information:
> <http://dadamailproject.com/cgi-bin/dada/mail.cgi/list/dadadev>
>
> Archive:
> <http://dadamailproject.com/cgi-bin/dada/mail.cgi/archive/dadadev>
Post:
mailto:[list_settings.discussion_pop_email]
Unsubscribe:
http://dadamailproject.com/cgi-bin/dada/mail.cgi/u/[list]/
List Information:
[PROGRAM_URL]/list/[list_settings.list]
- This mailing list is a public mailing list - anyone may join or leave, at any time.
- This mailing list is a group discussion list (unmoderated)
-
Start a new thread, email: dadadev@dadamailproject.com
This is the developer discussion mailing list for Dada Mail.
If you are just looking for support Dada Mail, consult the message boards at:
https://forum.dadamailproject.com
Documentation for Dada Mail:
Specifically, see the Error FAQ:
https://dadamailproject.com/d/FAQ-errors.pod.html
To post to this list, send a message to:
mailto:dadadev@dadamailproject.com
All subscribers of this list may post to the list itself.
Topics that are welcome:
- Constructive critiques on the program (I like, "x", but, "y" needs some work - here's an idea on how to make this better...)
- Bug/Error reports
- Bug fixes
- Request For Comments on any changes to the program
- Help customizing Dada Mail for your own needs
- Patches
- Language Translations
- Support Documentation/Doc editing, FAQ's, etc.
- Discussion of any changes that you would like to be committed to the next version of Dada Mail -
Dada Mail is on Github:
https://github.com/justingit/dada-mail/
If you would like to fork, branch, send over PRs, open up issues, etc.
Privacy Policy:
This Privacy Policy is for this mailing list, and this mailing list only.
Email addresses collection through this mailing list are used explicitly to work within this email discussion list.
We only collect email addresses through our Closed-Loop Opt-In system.
We don't use your email address for any other purpose.
We won't be sharing your email address with any other entity.
Unsubscription can be done at any time. Please contact us at: justin@dadamailproject.com for any help regarding your subscription, including removal from the mailing list.
All mailing list messages sent from us will include a subscription removal link, which will allow you to remove yourself from this mailing list automatically, and permanently.
All consent to use your email address for any other purpose stated at the time of the mailing list subscription will also be revoked upon mailing list removal.