Re: blacklists

From: "Mariano Absatz" <el.baby@PROTECTED>

In-Reply-To: Re: blacklists

Date: August 27th 2007

On 8/26/07, Justin Simoni justin@PROTECTED wrote:

It's probably these lines in the DADA/MailingList/Subscribes pm file:

[snip] foreach my $check_this_address(@$new_addresses) {
     my $errors = {};
     my $status = 1;

     $errors->{invalid_email} = 1 if
DADA::App::Guts::check_for_valid_email($check_this_address) == 1;
     if($args{-Type} ne 'black_list' || $args{-Type} ne
'moderators'){ if($li->{use_subscription_quota} == 1){ if(($num_subscribers + 1) >= $li-> {subscription_quota}){ $errors->{over_subscription_quota} = 1; } } } [/snip]

You could probably change them to:

[snip] foreach my $check_this_address(@$new_addresses) {
     my $errors = {};
     my $status = 1;

    if($args{-Type} ne 'black_list'){
            $errors->{invalid_email} = 1 if
DADA::App::Guts::check_for_valid_email($check_this_address) == 1; }
     if($args{-Type} ne 'black_list' || $args{-Type} ne
'moderators'){ if($li->{use_subscription_quota} == 1){ if(($num_subscribers + 1) >= $li-> {subscription_quota}){ $errors->{over_subscription_quota} = 1; } } } [/snip]

And you should at least get over the problem of not being able to validate a string that's not actually an email address, in the blacklist And get a little speedup, too

Thanx, Justin it worked OK actually, I did it a little more elegantly (within the same 'if' that was already there)

I'm enclosing the patch in case you want it

Attachments

dada_2.10.15-plain-bl-subscribe.patch

‹ Re: blacklists

Index

Re: Dada Mail Hosting Update ›

Email Address

You're OK with using your email address as your primary contact for this email discussion list; messages will be sent on your behalf

Unsubscribe at Anytime | Privacy Policy

This mailing list is a public mailing list - anyone may join or leave, at any time.
This mailing list is a group discussion list (unmoderated)
Start a new thread, email: dadadev@dadamailproject.com

This is the developer discussion mailing list for Dada Mail.

If you are just looking for support Dada Mail, consult the message boards at:

https://forum.dadamailproject.com

Documentation for Dada Mail:

https://dadamailproject.com/d

Specifically, see the Error FAQ:

https://dadamailproject.com/d/FAQ-errors.pod.html

To post to this list, send a message to:

mailto:dadadev@dadamailproject.com

All subscribers of this list may post to the list itself.

Topics that are welcome:

Constructive critiques on the program (I like, "x", but, "y" needs some work - here's an idea on how to make this better...)
Bug/Error reports
Bug fixes
Request For Comments on any changes to the program
Help customizing Dada Mail for your own needs
Patches
Language Translations
Support Documentation/Doc editing, FAQ's, etc.
Discussion of any changes that you would like to be committed to the next version of Dada Mail -

Dada Mail is on Github:

https://github.com/justingit/dada-mail/

If you would like to fork, branch, send over PRs, open up issues, etc.

Privacy Policy:

This Privacy Policy is for this mailing list, and this mailing list only.

Email addresses collection through this mailing list are used explicitly to work within this email discussion list.

We only collect email addresses through our Closed-Loop Opt-In system.

We don't use your email address for any other purpose.

We won't be sharing your email address with any other entity.

Unsubscription can be done at any time. Please contact us at: justin@dadamailproject.com for any help regarding your subscription, including removal from the mailing list.

All mailing list messages sent from us will include a subscription removal link, which will allow you to remove yourself from this mailing list automatically, and permanently.

All consent to use your email address for any other purpose stated at the time of the mailing list subscription will also be revoked upon mailing list removal.