Re: some other styling quirks (was: IE 5/Mac Template Breakage/body{} q's)

 
From: "Shane Clintberg" <shaneclintberg@PROTECTED>
Date: September 5th 2005

I'm done

  • I've moved the presentational dots in the header from the templates to the CSS

As already discussed at length: browsers that understand the CSS2 :before and :after pseudo-elements (FF/Moz, Opera) will show them; browsers that don't (IE) will not This change adds customizability in the long run, at the expense of IE not joining the party I heard no objections to leaving IE behind with this after asking multiple times, so there should be no surprises in my making this change

Justin, the only reason this was a "last-minute" change is because you only brought the issue to my attention recently That said, the change is a "customization extra" rather than something essential, so if it creates/has created extra work for you, I will happily revert this change and leave it for 2 11 Or you can do the same Or leave it as-is if you think it's fine Or whatever

  • I've changed the class name "spacer" to "floatclear" for the sake of clarity (The class is a CSS hack used to clear floats, not to add space )

Justin, I trust your criticism that "this is way too many changes this late" does not apply in this case, seeing as I asked specifically about making this change and you approved it

  • I have now fixed the header-collapsing bug that appeared as a consequence of floating all the header content (again, for added customizability) The header left-alignment bug also got fixed along the way

As bugfixed quite publicly on this list (N B : big thanks to everyone who helped out with the Mac screenshots! you guys are fantastic!), there were two equally robust options for the fix:

(1) clearing the floats by adding an extra,

into the list template & admin template, or:

(2) clearing the floats by using the multi-line CSS hack (commonly known as the PIE method) at:

http://www positioniseverything net/easyclearing html

As we've now tested across multiple platforms and browsers, either solution would do the job I went with the former because it seems (to me, as of this writing) the cleaner of the two, but I am not beholden to this solution over the other one So if everyone detests the empty-div markup in the templates and would prefer the "10-lines-of-CSS-hack" PIE solution, a switch to the PIE method further down the road is possible

Justin, the only reason this was a "last-minute" change is because I only learned of Mac OS9's failures of the previous float-clearing solution (which I plucked from http://annevankesteren nl/2005/03/clearing-floats) from Manfred recently, and because my lack of a Mac required the aforementioned team effort to try to resolve it As I mentioned above, this bugfix has already been thoroughly tested and proven reliable, but if it creates/has created more work for you, the header's logo can easily be "unfloated" and reverted to its version 2 9 X state, which, I trust, would remove that extra work

  • I have suggested the only fix I can think of for the bordered checkbox/radio-button bug in IE/Mac, Opera, et al, but it sounds like the changes required are more than Justin would prefer to do at this late stage [I repeat: it sounds like To me I don't mean to put words in anyone's mouth I could be misinterpreting, or could simply be wrong Lord knows it's happened before ]

Under these circumstances (again, as I have understood them), I have done and will be doing nothing to fix this bug The reason is simple: there is no other fix I know of to do Justin, this should not affect your workload, as I have made no changes

I am perfectly content with "putting this on the back burner" until after the 2 10 0 stable release I don't think I ever suggested otherwise

_s

I vote that we wrap things up, like yesterday, because I'm shipping an RC tomorrow I think we should see if we can't get a good fix for the IE5/Mac bug, and then say, "done", because that's the only thing I brought up (and the margin problem, which seems solved now)

An RC is a release that is as much like a real release as possible and only small bug fixes are corrected - if anything before the final release

So, put it on the back burner, please This is way too many changes this late You must remember that there's outside code that I need to change when you make style changes as well These are tools that I use in my consultation It makes me have to do extra work and would introduce bugs if I don't have time to put all my ducks in a row

Justin Simoni

  • This mailing list is a public mailing list - anyone may join or leave, at any time.
  • This mailing list is a group discussion list (unmoderated)
  • Start a new thread, email: dadadev@dadamailproject.com

This is the developer discussion mailing list for Dada Mail.

If you are just looking for support Dada Mail, consult the message boards at:

https://forum.dadamailproject.com

Documentation for Dada Mail:

https://dadamailproject.com/d

Specifically, see the Error FAQ:

https://dadamailproject.com/d/FAQ-errors.pod.html

To post to this list, send a message to:

mailto:dadadev@dadamailproject.com

All subscribers of this list may post to the list itself.

Topics that are welcome:

  • Constructive critiques on the program (I like, "x", but, "y" needs some work - here's an idea on how to make this better...)
  • Bug/Error reports
  • Bug fixes
  • Request For Comments on any changes to the program
  • Help customizing Dada Mail for your own needs
  • Patches
  • Language Translations
  • Support Documentation/Doc editing, FAQ's, etc.
  • Discussion of any changes that you would like to be committed to the next version of Dada Mail -

Dada Mail is on Github:

https://github.com/justingit/dada-mail/

If you would like to fork, branch, send over PRs, open up issues, etc.

Privacy Policy:

This Privacy Policy is for this mailing list, and this mailing list only.

Email addresses collection through this mailing list are used explicitly to work within this email discussion list.

We only collect email addresses through our Closed-Loop Opt-In system.

We don't use your email address for any other purpose.

We won't be sharing your email address with any other entity.

Unsubscription can be done at any time. Please contact us at: justin@dadamailproject.com for any help regarding your subscription, including removal from the mailing list.

All mailing list messages sent from us will include a subscription removal link, which will allow you to remove yourself from this mailing list automatically, and permanently.

All consent to use your email address for any other purpose stated at the time of the mailing list subscription will also be revoked upon mailing list removal.