That was a tricky one indeed!

You probably have too change the line:

if($li->{group_list} == 1){

into:

if($li->{group_list} == 1 && $errors->{msg_not_from_list_owner} ){

which means there is no need to verify whether the from address is on the list or not Will be more efficient too

Have a nice lunch, I go for a sleep now!

>

Hmm,

It's still working for me, I'm suspecting that this line (703 or so):

[snip]

 foreach(keys %$errors){
     $status = 0 if $errors->{$_} == 1;
     last;
 }

[/snip]

is incorrect Since hashes are fetched semi-randomly, whichever key you get first, will tell the fate of what status is set to and for whichever reason, it's a different order than me It should probably read:

[snip]

 foreach(keys %$errors){
     if($errors->{$_} == 1){
         $status = 0 ;
         last;
     }
 }

[/snip]

When I make that change, I can't post to a list, using a moderator's address I get something like:

[snip] List: k Logging into POP3 server: mail example com Trying secure login POP3 Login succeeded POP3 Server says: 59277.1124915581@PROTECTED

 Message count: 1
     Message is from: 'me@example
com'
      * From address if NOT from list owner address
     Moderation enabled



     *Message *is* from a moderator!
     Discussion Support enabled



     *Message is NOT from a subscriber

 Message did not pass verification - handling that


real soon!
     Error delivering message! Reasons:

         msg_not_from_subscriber
 removing message from server



 disconnecting from POP3 server

 Waiting 5 seconds before removal check



 Logging into POP3 server: mail
example
com
 Trying secure login



 POP3 Login succeeded

 POP3 Server says: <59310
1124915587@example
com>

 Message count: 0E0

[/snip]

Which is the same as you're getting, and wrong

I'll make that change and play around with the prog some more, most likely after lunch - good catch - thanks!

Can you please diff your copy of sub validate_msg with v1 36?

(Or do I have swallowed too much mango's and getting insane after all?)

The only difference was the diff between 1 35 and 1 36 - 1 36 just has some minor formatting changes

Justin Simoni

:: is an eccentric artist, living and working in Denver, Colorado :: URL: http://justinsimoni com :: PHO: 720 436 7701 :: Mailing List - http://justinsimoni com/mailing_list html

On Aug 24, 2005, at 2:05 PM, Frans Gouverne wrote:

> >

Messages from moderators are still ignored for discussion lists when moderators are allowed As a workaround I changed the following line from sub validate_msg (dada_bridge):

I'm not having trouble getting this to function incorrectly, here's what's printed if I manually start the process via the web interface: [snip]

---------------------------------------------------------------------

List: k Logging into POP3 server: mail example com Trying secure login POP3 Login succeeded POP3 Server says: 30858.1124837952@PROTECTED

 Message count: 1
     Message is from: 'me@example
com'
      * From address if NOT from list owner address
     Moderation enabled



     *Message *is* from a moderator!
     Discussion Support enabled



     *Message is NOT from a subscriber


     Processing Message



     Message being delivered!
 Message Details:
 --------------------------------------------------
 Subject: [k] THis is a test test test test hey!
     Finished Processing Message


 removing message from server



 disconnecting from POP3 server

 Waiting 5 seconds before removal check



 Logging into POP3 server: mail
example
com
 Trying secure login



 POP3 Login succeeded

 POP3 Server says: <30933
1124837958@hedwig
example
com>

 Message count: 0E0

[/snip]

I'm using basically what's in the CVS right now

What do you mean by "basically"? (Yes, I am getting suspicious now! ;-) Because this is what I get (latest dada_bridge v1 36 from CVS):

Message count: 1 Message is from: 'f gouverne@casema nl' * From address if NOT from list owner address Moderation enabled Message *is from a moderator! Discussion Support enabled *Message is NOT from a subscriber Message did not pass verification - handling that real soon! Error delivering message! Reasons:

msg_not_from_subscriber msg_not_from_subscriber on its way!

removing message from server disconnecting from POP3 server

Waiting 5 seconds before removal check Logging into POP3 server: mail gouverne nl Trying secure login Hmm, secure login failed, switching to regular login POP3 Login succeeded POP3 Server says: server10 firstfind nl Cyrus POP3 v2 0 16 server ready

Message count: 0E0

If I look at the code inside validate_msg, the email just can't pass verification, really it can't or I eat my hat:

if($li->{group_list} == 1){

print "\t\tDiscussion Support enabled \n" if $verbose;

my ($s_status, $s_errors) = $lh->subscription_check(-Email => $from_address);

if ($s_errors->{subscribed} != 1){ $errors->{msg_not_from_subscriber} = 1; <== $errors is set here!!!!!!!!!!!!!! print "\t\t*Message is NOT from a subscriber \n" if $verbose; }else{ print "\t\t*Message is from a current subscriber \n" if $verbose; $errors->{msg_not_from_moderator} = 0; $errors->{msg_not_from_list_owner} = 0; } }else{ print "\t\tDiscussion Support disabled \n"; }

So there is at least one element of $errors set and it is not cleared later on So there really must be an error And it should, because in case the from address was not from the moderator, msg_not_from_subscriber must be set indeed

Can you please diff your copy of sub validate_msg with v1 36?

(Or do I have swallowed too much mango's and getting insane after all?)

--

Post: dadadev@PROTECTED

Unsubscribe: http://mojo skazat com/cgi-bin/dada/mail cgi/u/dadadev/

List Information: http://mojo skazat com/cgi-bin/dada/mail cgi/list/dadadev

Archive:

--

Post: dadadev@PROTECTED

Unsubscribe: http://mojo skazat com/cgi-bin/dada/mail cgi/u/dadadev/

List Information: http://mojo skazat com/cgi-bin/dada/mail cgi/list/dadadev

Archive: http://mojo skazat com/cgi-bin/dada/mail cgi/archive/dadadev